Skip to content

courses: filtering for grade level confused by leading 1 (fixes #9257) #9274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

courses: filtering for grade level confused by leading 1 (fixes #9257) #9274

wants to merge 2 commits into from

Conversation

@Saby-Bishops
Copy link
Member

@Saby-Bishops Saby-Bishops commented Oct 29, 2025

fixes #9257 Normalize grade-level filtering to compare exact values and cover the behavior with a regression spec.

  • Coerce scalar field values to arrays in the table helpers so dropdown and advanced filters rely on strict equality.
  • Update the courses component spec, modernize its RxJS usage, and assert that the grade 1 filter excludes grade 12 rows.

https://chatgpt.com/codex/tasks/task_e_69026ca543ac832da92a063aaedbf888

@Saby-Bishops Saby-Bishops marked this pull request as ready for review October 30, 2025 18:45
@Saby-Bishops Saby-Bishops requested a review from Mutugiii October 30, 2025 20:13
Mutugiii
Mutugiii reviewed Oct 31, 2025
View reviewed changes
@Saby-Bishops Saby-Bishops requested a review from Mutugiii November 5, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmanuelbaa emmanuelbaa emmanuelbaa approved these changes

@Mutugiii Mutugiii Awaiting requested review from Mutugiii

Assignees

No one assigned

Labels

changes requested codex triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

courses: filtering for grade level confused by leading 1

4 participants

@Saby-Bishops @Mutugiii @emmanuelbaa